Separate Comment from pretty Options #2988
Merged
+38
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janmasrovira
force-pushed
the
jan-isabelle-comments
branch
from
ac7e654
to
5a49424
Compare
lukaszcz
approved these changes
Sep 2, 2024
lukaszcz
pushed a commit
that referenced
this pull request
Sep 2, 2024
I think it makes more sense to not have `State Options` as they are supposed to be immutable and have a separate `Input` effect for comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it makes more sense to not have
State Optionsas they are supposed to be immutable and have a separateInputeffect for comments.